Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(seek-bar): error when scrubbing after player reset #8257

Merged
merged 1 commit into from
May 31, 2023
Merged

fix(seek-bar): error when scrubbing after player reset #8257

merged 1 commit into from
May 31, 2023

Conversation

amtins
Copy link
Contributor

@amtins amtins commented May 2, 2023

Description

This PR fixes the error thrown when using the seekBar after the player has been reset.

seek-bar.webm

Specific Changes proposed

  • short-circuit the handleMouseMove function if the duration is NaN
  • update a reset-ui test case to reflect the player UI and ensure that the rest of the handleMouseMove function is not executed if duration is NaN
  • update a controls test case to meet the expected behavior

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Merging #8257 (d7d7e6e) into main (1491d71) will increase coverage by 82.36%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##           main    #8257       +/-   ##
=========================================
+ Coverage      0   82.36%   +82.36%     
=========================================
  Files         0      112      +112     
  Lines         0     7474     +7474     
  Branches      0     1800     +1800     
=========================================
+ Hits          0     6156     +6156     
- Misses        0     1318     +1318
Impacted Files Coverage Δ
src/js/control-bar/progress-control/seek-bar.js 55.73% <100.00%> (ø)

... and 111 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mister-ben mister-ben added the needs: LGTM Needs one or more additional approvals label May 12, 2023
@misteroneill misteroneill merged commit e73e05d into videojs:main May 31, 2023
edirub pushed a commit to edirub/video.js that referenced this pull request Jun 8, 2023
@amtins @edirub
fix(seek-bar): error when scrubbing after player reset (videojs#8257)
1170042
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mister-ben mister-ben mister-ben approved these changes

@misteroneill misteroneill misteroneill approved these changes

Assignees
No one assigned
Labels
needs: LGTM Needs one or more additional approvals
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amtins @misteroneill @mister-ben